fix: round compass margins and attribution position to nearest integers [android] #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes compass margins and attribution positions.
At the moment, we are casting density (float) to integer which is loosing decimal part. In same cases it leads to big differences. For example, Xiomi Redmi 12 has density 2.75.
Instead we should round to the nearest integer.
Checklist
yarn lint:fix
in the root folderyarn test
in the root folderyarn generate
in the root folderCHANGELOG.md
index.d.ts
)/example
)Screenshot OR Video