-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Style Docs #88
Add Style Docs #88
Conversation
Looks really nice, thanks a lot @birkskyum The URLs will still be the same as before, right? |
Can you please share some visuals of the new docs site? |
Clicking on things like "string" does not work yet: http://localhost:3000/maplibre-gl-style-spec/style-spec/types/#string |
The URLs will be exactly the same as before. The only one I changed was /other -> /deprecations because it's more informative of what the page contains. Here are some visuals of the menus - first on medium screens the menu one on the right will be pushed into a collapsible part on top of the main content, then on small screen the left menu will be hidden as well and toggled from the header. |
Aaah, right there are some links that should be updated. |
Go to http://localhost:3000//layers#paint-background-background-opacity, click on "number" -> page not found |
I think basically not all titles in the "types" page have links. |
There's just too much code here from my point of view for a documentation site. |
@birkskyum — It's really nice. I welcome the move to the "solid stack" of modern tools. It builds easy enough for me and as Oliver noted, I too found a few broken links. I think those will get sorted. The documentation shortcuts (see below) are really nice, and I believe preserve what we had with batfish. Overall, I like the documentation upgrade. |
I am unable to build:
|
From the documentation of SolidStart:
Sounds a little too bleeding edge to me... |
This is a big improvement over Mapbox Batfish from what I can tell, but I feel that it repeats the same mistake in that we don't have the capacity to keep a partly home grown JS+HTML+CSS stack up to date. The JS ecosystem especially moves pretty fast, and I fear this will be completely outdated in as little as 2 years from now. In addition:
I worked with Vite for well over a year and it is a pleasure to use when developing SPAs and otherwise highly interactive web applications, where the loading time in the past could be measured in minutes. However even really complicated static sites that are generated from scratch on every change do not take more than a couple of seconds to render. I don't think choosing Vite is worth the added complexity. |
@louwers , I had all the routes beneath a /en/ url path initially, would that be a suitable internationalization strategy to you going forward? So that we could add /xx/ languages down the line. |
I believe this is still be the plan. |
@louwers Did you run |
Thanks for all the feedback. I will look into fixing the links. The other mentioned features/refactors are good suggestions, but they go beyond the capabilities of the existing site, so it'll have to happen in future efforts to avoid feature creep. In terms of why this stack was selected, see the reasoning in the ticket #126 . |
Closes maplibre/maplibre-gl-js-docs#400 (Repo split / migration), Closes #126 (New docs)
The new docs can be launched by running:
cd docs
npm i
npm run dev