Update style spec #124
Update style spec #124
Conversation
package.json
Outdated
| "mapbox-gl-inspect": "^1.2.2", | ||
| "mapbox-gl-style-spec": "^8.11.0", | ||
| "mapbox-gl": "^0.34.0", | ||
| "mapbox-gl-inspect": "lukasmartinelli/mapbox-gl-inspect#7108dab80f", |
There was a problem hiding this comment.
This points at the git commit because the latest version of mapbox-gl-inspect hasn't been released to npm yet.
There was a problem hiding this comment.
lemme release that.
There was a problem hiding this comment.
mapbox-gl-inspect@1.2.3 published
|
Tried it out!! Works well. Merge master and then merge the PR!
|
|
Unfortunately all the I think the best bet of updating to the new version is to submit a PR to mapbox/mapbox-gl-js to compile |
|
Ah I see we should be using https://www.npmjs.com/package/@mapbox/mapbox-gl-style-spec however that is in ES6 so we need to precompile |
config/webpack.loaders.js
Outdated
| @@ -6,7 +6,7 @@ module.exports = [ | |||
| }, | |||
| { | |||
| test: /\.jsx?$/, | |||
| exclude: /(node_modules|bower_components|public)/, | |||
| exclude: /(.*node_modules(?!\/@mapbox\/mapbox-gl-style-spec)|bower_components|public)/, | |||
There was a problem hiding this comment.
Now compiling @mapbox/mapbox-gl-style-spec
|
Uggh sorry it is so much trouble. I am not the biggest fan of the monorepo of GLJS 😢 |
|
That moment where you forget you modified @mapbox/mapbox-gl-style-spec/migrate/v8.js to reference |
|
On hold waiting for PR to be merged and npm module released mapbox/mapbox-gl-js#4563 |
…ate-mapbox-style-spec Conflicts: package.json
|
This PR should be passing the tests now, but need further consideration as |
|
Well this is a fun PR... My best guess for the failing tests on windows is that this regexp isn't matching therefore we aren't building the @mapbox/mapbox-gl-style-spec (see https://github.com/orangemug/editor/blob/c552838fddb41ad3ba2d8cf4187a860865933a98/config/webpack.loaders.js#L9). That is kinda of a hack anyway because babel shouldn't need to touch that module, however the built module isn't ES5... I'll find a windows box later and try to diagnose, but it might be better to raise a few issues on @mapbox/mapbox-gl-style-spec repo and wait for the fixes. |
|
Yeah one would think JavaScript is cross platform.. but I ran into many troubles with Linux/OSX/Windows |
|
I currently don't have access to a windows machine. If anyone would like to take a look into the windows issue please feel free, see #124 (comment) for details |
|
I've found the issue, see webpack/webpack#2073 |
I'm a little unsure this is a 100% working PR, mainly because we're missing good test coverage, which will probably be my next task. When reviewing this PR can someone checkout the branch and give it a test locally.