Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add brew Formula #623

Merged
merged 2 commits into from
May 24, 2023
Merged

add brew Formula #623

merged 2 commits into from
May 24, 2023

Conversation

tomeronen
Copy link
Contributor

@tomeronen
Copy link
Contributor Author

wil add another pr to also support aarch64

stepankuzmin
stepankuzmin approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
Thanks, @tomeronen!

@nyurik
Copy link
Member

nyurik commented Mar 28, 2023

Thanks! I can merge it as is, but I do have a big concern with the hardcoded version and hash values -- it will be a massive pain to maintain them by hand. Are there any CI automation tools to update them after publish?

@tomeronen
Copy link
Contributor Author

i am searching for how this can be updated through a CI tool :)

@nyurik
Copy link
Member

nyurik commented Apr 8, 2023

@tomeronen hi, any luck?

@nyurik nyurik merged commit 8f020aa into maplibre:main May 24, 2023
@nyurik nyurik mentioned this pull request May 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepankuzmin stepankuzmin stepankuzmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomeronen @nyurik @stepankuzmin