Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sqlx to v0.7 #743

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Upgrade sqlx to v0.7 #743

merged 1 commit into from
Jul 4, 2023

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Jul 4, 2023

This is mostly a noop, just updating to the new way of storing cached queries and a few other changes per https://github.com/launchbadge/sqlx/blob/main/CHANGELOG.md#070---2023-06-30

Note that this uses some of the code from #729 (thanks @upsicleclown !)

A minor unrelated change - a reformat of martin/release.toml

@birkskyum
Copy link
Member

I see a change between actix - tokio wrt the sqlx - are they interchangeable for us?

@nyurik
Copy link
Member Author

nyurik commented Jul 4, 2023

@birkskyum yes, actix uses tokio internally anyway. Also, see this sqlx changelog comment:

The runtime-actix-* features have been deleted. They were previously changed to be aliases of their runtime-tokio-* counterparts for backwards compatibility reasons, but their continued existence is misleading as SQLx has no special knowledge of Actix anymore.
To fix, simply replace the runtime-actix-* feature with its runtime-tokio-* equivalent.

@nyurik nyurik merged commit 144e10f into maplibre:main Jul 4, 2023
@nyurik nyurik deleted the update-sqlx branch July 4, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants