shield symbolizer not on road

[ramunasd]

Data is correct, style is not changed. Don't know after which commits this happens, i'm using latest version (03422de)

[springmeyer]

Thanks for the report. Would it be possible for you to isolate that geometry to produce a simple testcase?

[ramunasd]

Data is here http://openmap.lt/#l=54.91423,25.77223,15,L
You can browse for more examples and download dierctly from OSM.

[springmeyer]

Can you still replicate if you step back to 07ec5c3 ?

[springmeyer]

c7960a2 also might be suspect, so try with the one proceeding: 8cf9a5a

[ramunasd]

8cf9a5a renders good

[springmeyer]

thanks, and if you move ahead one commit, to c7960a2, can you replicate the problem again?

[ramunasd]

c7960a2 looks good

[springmeyer]

okay, going forward, f6fa57d should work, but perhaps 7b10400 does not?

[springmeyer]

btw, I am unable to replicate this with the osm.xml (master) and mapnik (master) and data downloaded for your example region via http://api.openstreetmap.org/api/0.6/map?bbox=25.663,54.8419,25.9194,54.9695

[ramunasd]

f6fa57d renders good, 7b10400 cannot compile:

In file included from include/mapnik/geometry.hpp:27:0,
                 from include/mapnik/feature.hpp:29,
                 from include/mapnik/parse_path.hpp:29,
                 from include/mapnik/symbolizer.hpp:28,
                 from include/mapnik/building_symbolizer.hpp:28,
                 from include/mapnik/rule.hpp:27,
                 from include/mapnik/feature_type_style.hpp:27,
                 from bindings/python/mapnik_style.cpp:29:
include/mapnik/vertex_vector.hpp:116:5: error: declaration of âunsigned int mapnik::vertex_vector<T>::vertex(unsigned int, mapnik::vertex_vector<T>::coord_type_, mapnik::vertex_vector<T>::coord_type_) constâ [-fpermissive]
include/mapnik/vertex.hpp:44:8: error: changes meaning of âvertexâ from âstruct mapnik::vertex<T, 2>â [-fpermissive]
scons: **\* [bindings/python/mapnik_style.os] Error 1
scons: building terminated because of errors.
make: **\* [mapnik] Error 2

[lightmare]

@ramunasd try to cherry-pick 4625e50 , could fix compilation

[ramunasd]

Updated to latest 19ed871 and after full compilation mapnik renders good.
Is this some cross linking issue?

[ramunasd]

Something still goes not very well, 19ed871 renders shields not on road - http://osmlt.openmap.lt/14/9366/5185.png

[artemp]

@ramunasd - could you post relevant part of your style, thanks!

[ramunasd]

@artemp sure https://github.com/ramunasd/openmap.lt/blob/master/osmlt/inc/layer-roads-text.xml.inc

[artemp]

@ramunasd - thanks!

@springmeyer - well, placement="line" in ShieldSymbolizer fixes this but this is not the end of story -> symbolizer_helpers are in a real big mess at the moment.

[artemp]

@ramunasd - previous behaviour is restored in 822531a

Note: ShieldSymbolizer placement defaults to placement="point"

[ramunasd]

@artemp 822531a renders good, but many tests fails

[artemp]

@ramunasd - what tests?

[ramunasd]

visual tests

[artemp]

@ramunasd - ok, thanks. BTW, all visual tests are passing for me.

[springmeyer]

this was fixed fully in 6f17428