Skip to content

Loading…

shield symbolizer not on road #1350

Closed
ramunasd opened this Issue · 22 comments

4 participants

@ramunasd

bug

Data is correct, style is not changed. Don't know after which commits this happens, i'm using latest version (03422de)

@springmeyer
Mapnik member

Thanks for the report. Would it be possible for you to isolate that geometry to produce a simple testcase?

@ramunasd

Data is here http://openmap.lt/#l=54.91423,25.77223,15,L
You can browse for more examples and download dierctly from OSM.

@springmeyer
Mapnik member

Can you still replicate if you step back to 07ec5c3 ?

@springmeyer
Mapnik member

c7960a2 also might be suspect, so try with the one proceeding: 8cf9a5a

@ramunasd

8cf9a5a renders good

@springmeyer
Mapnik member

thanks, and if you move ahead one commit, to c7960a2, can you replicate the problem again?

@ramunasd

c7960a2 looks good

@springmeyer
Mapnik member

okay, going forward, f6fa57d should work, but perhaps 7b10400 does not?

@springmeyer
Mapnik member

btw, I am unable to replicate this with the osm.xml (master) and mapnik (master) and data downloaded for your example region via http://api.openstreetmap.org/api/0.6/map?bbox=25.663,54.8419,25.9194,54.9695

@ramunasd

f6fa57d renders good, 7b10400 cannot compile:
```g++ -o bindings/python/mapnik_style.os -c -march=core2 -DHAVE_JPEG -DBOOST_REGEX_HAS_ICU -ansi -Wall -pthread -ftemplate-depth-300 -DLINUX -DBOOST_SPIRIT_THREADSAFE -DMAPNIK_THREADSAFE -O3 -finline-functions -Wno-inline -Wno-parentheses -Wno-char-subscripts -DNDEBUG -DHAVE_CAIRO -DHAVE_PYCAIRO -fPIC -Ideps/agg/include -I. -Iinclude -I/usr/local/include -I/usr/include -I/usr/include/freetype2 -I/usr/include/libxml2 -I/usr/include/postgresql -I/usr/include/python2.7 -I/usr/include/cairomm-1.0 -I/usr/lib/x86_64-linux-gnu/cairomm-1.0/include -I/usr/include/cairo -I/usr/include/sigc++-2.0 -I/usr/lib/x86_64-linux-gnu/sigc++-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/pycairo bindings/python/mapnik_style.cpp
In file included from include/mapnik/geometry.hpp:27:0,
from include/mapnik/feature.hpp:29,
from include/mapnik/parse_path.hpp:29,
from include/mapnik/symbolizer.hpp:28,
from include/mapnik/building_symbolizer.hpp:28,
from include/mapnik/rule.hpp:27,
from include/mapnik/feature_type_style.hpp:27,
from bindings/python/mapnik_style.cpp:29:
include/mapnik/vertex_vector.hpp:116:5: error: declaration of âunsigned int mapnik::vertex_vector::vertex(unsigned int, mapnik::vertex_vector::coord_type, mapnik::vertex_vector::coord_type) constâ [-fpermissive]
include/mapnik/vertex.hpp:44:8: error: changes meaning of âvertexâ from âstruct mapnik::vertexâ [-fpermissive]
scons: *** [bindings/python/mapnik_style.os] Error 1
scons: building terminated because of errors.
make: *** [mapnik] Error 2

@lightmare

@ramunasd try to cherry-pick 4625e50 , could fix compilation

@ramunasd

Updated to latest 19ed871 and after full compilation mapnik renders good.
Is this some cross linking issue?

@ramunasd ramunasd closed this
@ramunasd ramunasd reopened this
@ramunasd

Something still goes not very well, 19ed871 renders shields not on road - http://osmlt.openmap.lt/14/9366/5185.png

@artemp artemp closed this
@artemp artemp reopened this
@artemp
Mapnik member

@ramunasd - could you post relevant part of your style, thanks!

@artemp
Mapnik member

@ramunasd - thanks!

@springmeyer - well, placement="line" in ShieldSymbolizer fixes this but this is not the end of story -> symbolizer_helpers are in a real big mess at the moment.

@artemp
Mapnik member

@ramunasd - previous behaviour is restored in 822531a

Note: ShieldSymbolizer placement defaults to placement="point"

@artemp artemp closed this
@ramunasd

@artemp 822531a renders good, but many tests fails

@artemp
Mapnik member

@ramunasd - what tests?

@ramunasd

visual tests

@artemp
Mapnik member

@ramunasd - ok, thanks. BTW, all visual tests are passing for me.

@artemp artemp was assigned
@springmeyer
Mapnik member

this was fixed fully in 6f17428

@springmeyer springmeyer added a commit that referenced this issue
@springmeyer springmeyer close #1548 with explict handling of point geometries and amend 629d768
… for cairo/grid renderers to ensure proper placement on lines (refs #1604,#1350,#1607)
7d408d5
@PetrDlouhy PetrDlouhy added a commit to PetrDlouhy/mapnik that referenced this issue
@springmeyer springmeyer use middle_point placement algorithm for marker POINT placement on li…
…nes - closes #1604 - refs #1350 and refs #1607
e1fdced
@PetrDlouhy PetrDlouhy added a commit to PetrDlouhy/mapnik that referenced this issue
@springmeyer springmeyer close #1548 with explict handling of point geometries and amend 629d768
… for cairo/grid renderers to ensure proper placement on lines (refs #1604,#1350,#1607)
62818d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.