Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libboost_python detection for boost1.71. #227

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

sebastic
Copy link
Contributor

@sebastic sebastic commented Jun 4, 2020

The libboost-python-dev package in Debian changed from containing:

libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python.a
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python.so
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python27.a
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python27.so
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python3-py38.a
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python3-py38.so
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python3.a
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python3.so
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python38.a
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python38.so

To only containing:

libboost-python1.71-dev: /usr/lib/x86_64-linux-gnu/libboost_python38.a
libboost-python1.71-dev: /usr/lib/x86_64-linux-gnu/libboost_python38.so

The libboost-python-dev package in Debian changed from containing:
```
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python.a
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python.so
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python27.a
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python27.so
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python3-py38.a
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python3-py38.so
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python3.a
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python3.so
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python38.a
libboost-python1.67-dev: /usr/lib/x86_64-linux-gnu/libboost_python38.so
```
To only containing:
```
libboost-python1.71-dev: /usr/lib/x86_64-linux-gnu/libboost_python38.a
libboost-python1.71-dev: /usr/lib/x86_64-linux-gnu/libboost_python38.so
```
@snickell
Copy link

snickell commented Sep 3, 2020

Based on my testing, this patch also fixes the auto-detection of boost_python on OSX homebrew, and Ubuntu.

@artemp any chance you could check this patch out and consider merging? Since self-compilation is required, and this fix makes the build work again on OSX, Debian and Ubuntu, many users will be positively impacted by merging.

It would also merge, and fix build on OSX at least (and I think Ubuntu?), on the 3.0.x branch.

@snickell
Copy link

snickell commented Sep 3, 2020

OSX homebrew:

➜  lib python3 -c "import platform ; print(platform.system())"
Darwin
➜  lib ls libboost_python*
libboost_python38-mt.a     libboost_python38-mt.dylib libboost_python38.a        libboost_python38.dylib
➜  lib pwd
/usr/local/lib
➜  lib   

@artemp artemp merged commit 739276f into mapnik:master Sep 8, 2020
@artemp
Copy link
Member

artemp commented Sep 8, 2020

@sebastic @snickell - merged, thanks

@sebastic sebastic deleted the boost1.71 branch September 8, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants