-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Predicate modifier fix & fixed gh workflow #389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, in "remove mappings" this makes some sense, but before I approve: isn't it better to fix the code that assumes that PREDICATE_MODIFIER
MUST be present, rather than injecting an empty column?
This error came into being after we included |
No I am thinking more to remove predicate_modifier from KEY_FEATURES everytime KEY_FEATURES is used as a means to subset a dataframe.. Or something along this line. I don't know exactly what is right here - from a user perspective, I just don't want empty |
predicate_modifier
is a optional column but is essential forgroupBy
while removing mappings etc. This adds a blank column if the column does not exist. This PR is in response to Bug: Mondo ingest (lexmatch pipeline) monarch-initiative/mondo-ingest#343update_context
workflow.