Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predicate modifier fix & fixed gh workflow #389

Merged
merged 11 commits into from
Jul 10, 2023
Merged

Conversation

hrshdhgd
Copy link
Contributor

@hrshdhgd hrshdhgd commented Jul 7, 2023

Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, in "remove mappings" this makes some sense, but before I approve: isn't it better to fix the code that assumes that PREDICATE_MODIFIER MUST be present, rather than injecting an empty column?

@hrshdhgd
Copy link
Contributor Author

hrshdhgd commented Jul 7, 2023

This error came into being after we included predicate_modifier into KEY_FEATURES. Do you mean something like 06a227c?

@matentzn
Copy link
Collaborator

matentzn commented Jul 7, 2023

No I am thinking more to remove predicate_modifier from KEY_FEATURES everytime KEY_FEATURES is used as a means to subset a dataframe.. Or something along this line. I don't know exactly what is right here - from a user perspective, I just don't want empty predicate_modifier columns to show up in my data frames when I am processing them with sssom py.

@hrshdhgd hrshdhgd requested a review from matentzn July 10, 2023 17:54
@hrshdhgd hrshdhgd merged commit 42b1cc8 into master Jul 10, 2023
@hrshdhgd hrshdhgd deleted the predicate-modifier-fix branch July 10, 2023 19:36
@hrshdhgd hrshdhgd changed the title Predicate modifier fix Predicate modifier fix & fixed gh workflow Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants