Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes unnecessary external_context.py, clean Makefile & update dependencies. #394

Merged
merged 7 commits into from
Jul 18, 2023
Merged

Removes unnecessary external_context.py, clean Makefile & update dependencies. #394

merged 7 commits into from
Jul 18, 2023

Conversation

hrshdhgd
Copy link
Contributor

@hrshdhgd hrshdhgd commented Jul 18, 2023 •
edited
Loading

  • Removes the need of external_context.py
  • Directly wget the sssom.external.context.jsonld file into src/sssom/ instead of schema and the copy back.
  • sssom.external.context.jsonld now resides in only one location and make deploy-dm has less steps!
  • Fixed get_external_jsonld_context()
  • Fixes Fix all the other ^ dependencies to '>='.  #392: Updated toml file ^X.X.X => >=X.X.X
  • Fixes Remove scipy dependency #393 : Moved scipy to extras.

This is relevant to #390

@hrshdhgd hrshdhgd requested review from matentzn and removed request for matentzn July 18, 2023 14:35
@hrshdhgd hrshdhgd requested a review from matentzn July 18, 2023 14:43
@hrshdhgd hrshdhgd changed the title Removes unnecessary external_context.py and clean Makefile. Removes unnecessary external_context.py, clean Makefile & update dependencies. Jul 18, 2023
matentzn
matentzn reviewed Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Just a few questions!

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
tests/test_parsers.py Show resolved Hide resolved
matentzn
matentzn approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic thank you!!

@hrshdhgd hrshdhgd merged commit 70a14b1 into master Jul 18, 2023
6 checks passed
@hrshdhgd hrshdhgd deleted the pr-390 branch July 18, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove scipy dependency Fix all the other ^ dependencies to '>='.
2 participants
@hrshdhgd @matentzn