Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document testing SSSOM-Py against a development version of the schema. #374

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

gouttegd
Copy link
Contributor

  • docs/ have been added/updated if necessary
  • make test has been run locally (no need)
  • tests have been added/updated (not applicable)
  • CHANGELOG.md has been updated. (no need)

This PR updates the CONTRIBUTING.md document to add a section about how to locally run the test suite, and especially how to locally run SSSOM-Py’s test suite, since changes to SSSOM’s LinkML schema can negatively impact the Python implementation.

It also updates the pull request template to add a checkbox to remind contributors that any change to the LinkML schema should be tested against SSSOM-Py (or rather, SSSOM-Py should be tested against the new schema).

Update the CONTRIBUTING.md document to add a section about how to
locally run the test suite, and especially how to locally run SSSOM-Py's
test suite.

Update the pull request template to add a checkbox to remind
contributors that any change to the LinkML schema should be tested
against SSSOM-Py (or rather, SSSOM-Py should be tested against the new
schema).
@gouttegd gouttegd self-assigned this Jul 22, 2024
@gouttegd gouttegd added the documentation Improvements or additions to documentation label Jul 22, 2024
@gouttegd gouttegd requested a review from matentzn July 22, 2024 17:23
Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thank you so much for designing that process! That takes a huge load of my soul!

@matentzn matentzn requested a review from hrshdhgd July 30, 2024 14:00
@matentzn
Copy link
Collaborator

@hrshdhgd Can you also review / approve please? Thank you!

Copy link
Contributor

@hrshdhgd hrshdhgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome as always!!

@gouttegd gouttegd merged commit ff8b192 into master Jul 30, 2024
3 checks passed
@gouttegd gouttegd deleted the testing-against-sssompy branch July 30, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants