Hillshading

[usrusr]

Open todos:

1. Alignment is sometimes off
2. unfiltered upscaling is on Android
3. the conversion from height values is just placeholder quality
4. The decision between AwtLuminanceShadingComposite and AlphaComposite should either be properly exposed to client applications (or themes) or it should go (properly hardcoded, without pretensions of flexibility). Without a consistent implementation on the Android side I would suggest staying with alpha blending on both sides (I would personally prefer luminance blending, since I expect it to work better with existing themes)

[usrusr]

alignment and unfiltered upscaling on android are fixed with latest commit (by switching from matrix-contolled scaling to src-rect/dest-rect controlled scaling), sorry for being a moving target

[devemux86]

Thanks!

I'd like to parse the PR for some improvements like code formatting, methods order and rebase / squash in a new branch to be able to continue there.
Have you other immediate work to push or PR will be quiet for some time?

[usrusr]

I expect work on todo.3 (better hgt to shading) to be pretty much self-contained in a new implementation of o.mf.m.layer.hills.ShadingAlgorithm so it will smoothly merge with any changes you make to the stuff in the current PR. I'll just do it in a new branch so that I can keep the merging effort with your changes to the current PR on my side.

[devemux86]

I'll merge this PR and any improvements in a new hillshading branch for users to start playing with it.
Then you can fetch it and post any new changes in that branch as new future PR, in order to update that.

BTW you can use GitHub markdown task lists in your first comment to indicate the completed tasks.

[devemux86]

Rebased, squashed and merged in hillshading branch via f66021f, with minor improvements via 16be706.

Can you post any future PR work on that branch?

[devemux86]

Since regular Mapsforge API can continue as usual and for broader user visibility..
I rebased, squashed and merged via 7dd483c, with minor improvements via 1928ec9.

I included the hillshading rules in new renderTheme-v6 XML schema definition.
Also on Desktop Samples the 1st argument can be used as dem folder.