Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate contact info #295

Open
Self-Perfection opened this issue Oct 19, 2015 · 2 comments
Open

Duplicate contact info #295

Self-Perfection opened this issue Oct 19, 2015 · 2 comments

Comments

@Self-Perfection
Copy link

Please consider this cinema
Currently it has following tags:

<tag k="contact:phone" v="+7 499 2559692; +7 499 2559237; +7 495 6057306"/>
<tag k="contact:website" v="http://www.kinocenter.ru"/>
<tag k="phone" v="+7 (499) 255-96-92, 255-92-37; (495) 605-73-06"/>
<tag k="website" v="http://www.kinocenter.ru"/>

There is duplicate info in OSM database. And all this duplicate is stored in .mwm:
screenshot-15-10-20-01-50-53
The POI is probably improperly tagged, but I believe map conversion should omit at least obvious duplicates for tags (website in this example).
It seems to be a good idea to preparse phone numbers to show them to a user in identical way (e.g. all with dashes or all with spaces to divide digit groups). Such preparsing during map conversion might allow avoiding storing less obvious duplicated phone numbers in this example.

@biodranik
Copy link
Contributor

Thanks for reporting it!

Technically, it is not obvious, how to parse and preprocess phone numbers for different countries, but it is a good idea in general - to have all phones in UI in similar “good” format.

Better way, in my opinion, would be to fix this data directly in OSM, so everyone benefit from correct changes.

@chuckwagoncomputing
Copy link

This has been fixed in OSM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants