-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve build/test infrastructure to support IDEA 2022.2/2022.3 and Java 17 #113
Conversation
…ava 17 * Use Java 11 for <2022.2 and Java 17 for >=2022.2 * Upgrade Gradle to 7.5.1 for Java 17 and fixup build script accordingly * Upgrade `intellij-gradle-plugin` for IDEA >=2022.2 * Remove Kotlin (not actually used, but messes with classpath) * Rearrange stuff around JUnit * Fixup several build warnings
@filiphr, please take a look. |
Thanks a lot for your work on this @unshare. I'll have a look at the failing tests on 2022.3. I don't think that the failures are that big, it is only some small text formatting changes that have been done in IntelliJ |
* Change use of report to non deprecated property * Do not add tail text for lookups * Adapt tests to use message from IntelliJ instead of manually crafted
@unshare I checked this out locally and I've fixed some of the problems in the tests. By the way, what kind of a machine do you have? I have an Intel Mac and I couldn't run the tests. I had to use a snapshot version of the Gradle IntelliJ Plugin to run the tests properly. The build is also green for me when using LATEST-EAP-SNAPSHOT. I think that we can remove 223.6646.99-EAP-SNAPSHOT from the GItHub matrix build |
Great! You did manage to get a green checkmark.
Stack trace for 223 EAP follows, but beware `master` is already pretty much refactored around this
I've always suspected IntelliJ does some workarounds against Java modularity (Project Jigsaw), and this one is kind of proof. Removed the said last known good build from CI as it makes no difference when tested on a Linux-based CI. |
I also had a lot of JNA not available stuff locally. Using 1.10.0-SNAPSHOT from the gradle-intellij-plugin took all of that away. Seems like the plugin is configuring the build somehow and disables some things for IntelliJ. Thanks a lot for your work on this. I'll merge it shortly and yes #112 was next on my list to review and merge. Didn't have the time yesterday (I wanted to check it out locally and see what was causing this) |
intellij-gradle-plugin
for IDEA >=2022.2