-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#16 autocomplete for public fields #26
#16 autocomplete for public fields #26
Conversation
Any idea why the tests aren't working? They work locally. |
@thunderhook seems like they are only failing on the LATEST-EAP-SNAPSHOT. I will allow failures on the latest 😄. Had a quick glance over the PR and it looks OK. I think that I have some tests locally (I was looking into doing this as well). |
@thunderhook I've done some fixes on master so the build can work with the LATEST_EAP_SNAPSHOT as well. You can have a look at 0178598 (a branch where I was trying out public fields). There are some data fixture prepared in there. Will you be able to add some tests with those fixtures? The tests are more or less the same as the getters / setters. |
I hope I have rebased correctly. I've added the fixture tests - please have a look. |
@thunderhook I think that something went wrong with the rebase. I am seeing commits and changes from master here. Can you try again perhaps? You can also create a new branch and aoply your commits there. You can then force push that local branch to the branch 9f this commit. This way the PR will be properly updated. Thanks |
@filiphr I am sorry, this whole pull request is a mess. 💣 The tests worked fine (locally) before I did this catastrophical "kind of" rebase. Am I even helping or do I cause more trouble by further commiting? 😃 Please, just tell me if I should stop contributing. |
Any progress on this. Waiting for support via public fields (without getter/setter) |
This has slipped through. I am sorry @thunderhook.
Contributing is always helping out. You should never stop 😄.
I'll try to merge this PR this week. |
And I managed to this this today. Part of PR #40. @thunderhook I kept your commit with your name as well. Thanks a lot and sorry for taking me so much time to merge it |
Implemented the auto-completion for targets with public non-static non-final fields.
The source auto-completion works with any public field.
Sadly there weren't any tests for completion, so I couldn't provide additional tests.