Improved responsive design of find project page #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the responsive design of the image tile container of the find project component: Before, the number of columns of image tiles to show per page (and thus the size of each image tile) was determined based on the window aspect ratio only. With this PR, a reasonable image tile size between 128 and 512 px is determined based on the actual available space.
As a result, vertical space is used more efficiently while minimizing the cases in which the content of the component overflow the project view and thus require the user to scroll between imagery and controls.
Also, the size of the icon buttons on the image overlay (selection and magnify buttons) now adapt to the image tile size for better usability on smaller image sizes.