Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken map labeling spanning multiple raster tiles #35

Closed
procogent opened this issue Aug 4, 2016 · 10 comments
Closed

Broken map labeling spanning multiple raster tiles #35

procogent opened this issue Aug 4, 2016 · 10 comments
Assignees
Labels

Comments

@procogent
Copy link

Map label elements that span multiple raster tiles are frequently cut off (only appearing on one of the tiles) resulting in odd artifacts.

z10 example
z11 example

@klokan
Copy link
Member

klokan commented Aug 5, 2016

Acknowledged. We will discuss @petrsloup, how to increase the buffers around tiles to avoid this problem.

@klokan
Copy link
Member

klokan commented Aug 29, 2016

We start to work actively on this issue. Upgrade of Mapbox GL Native did not solve the problem.
The next step is digging into the combination of input data (vector tiles + JSON style) on the sample area and debug tests on the GL Native.

@petrsloup
Copy link
Member

I did some testing and it's possible there are actually two separate issues:
image

  • Sometimes, two labels are present very close to each other in both tiles, but it looks like different label is chosen to be used in different tile (blue circles).
  • And sometimes the label is present only in one of the tiles and not the other (blue circle).

Since this issues is also happening when using mapbox-gl-native directly (center+zoom+dimensions), there is probably nothing we can do on tileserver-gl side -- it's either bug in mapbox-gl-native or the data.

We will look into the tiles data to better understand what exactly is going on.

@klokan
Copy link
Member

klokan commented Aug 29, 2016

Related PR: mapbox/mapbox-gl-native#3357

@klokan
Copy link
Member

klokan commented Aug 29, 2016

@petrsloup - config for "MapMode::Still"?

@mikemorris
Copy link

mikemorris commented Aug 29, 2016

This appears like you're hitting mapbox/mapbox-gl-native#3582, which can be fixed by adding symbol-avoid-edges: true to the clipped label layer in the style. We're considering making this default behavior and would appreciate any feedback you have, or edge cases that this fails to address.

@petrsloup
Copy link
Member

This indeed seems to help. Adding "symbol-avoid-edges": true to the affected layer ensures the labels are not rendered when touching the tile edge:
image
But it also removes some labels which were rendered correctly (such as "Fremont" or "Harbor Island").

However, it needs to be used carefully, since adding it to all layers removes unnecessarily many features (such as roads, etc.), which work correctly on the edges:
image

@beikehanbao23
Copy link

I've the same problem,text lable spanning multiple raster tiles.

is there a metatile before export tiles in mapbox-gl-native ? like geowebcache?

@petrsloup
Copy link
Member

There is currently nothing to be done on the server side.

This is more about the preparation of the data (tuning buffer sizes) and styles (sensible font sizes etc.).

@muesliq
Copy link

muesliq commented May 9, 2018

This might (still) be a Mapbox GL Native bug: mapbox/mapbox-gl-native#11838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

7 participants