Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map pins cover map marker / POIs #762

Closed
msmollin opened this issue Oct 28, 2016 · 5 comments
Closed

Map pins cover map marker / POIs #762

msmollin opened this issue Oct 28, 2016 · 5 comments
Labels

Comments

@msmollin
Copy link
Member

  • Device name:
    Nexus 5
  • Android Version:
    4.4.4
  • App build number:
    master-1795
  • What did you expected to happen?
    When I tapped on a map marker, a pin would appear with the pin tip on the marker.
  • What happened instead?
    The pin basically covers the marker.
  • Attach a screenshot
    screenshot_2016-10-28-16-25-59
@msmollin msmollin added the bug label Oct 28, 2016
@tallytalwar
Copy link
Member

This could be because of wrong anchor set in the style sheet or anchoring is broken on current master of tangram-es. @blair1618 I think we saw something similar on tizen (when we were testing sticker vs maker work).

@karimnaaji
Copy link
Member

It's none of that, the marker in that case does not know to which other label it is linked to, parenting is broken because the parenting only exists at stylesheet creation. It seems to be more a problem of how our markers system would let markers link to already existing label features.

@tallytalwar
Copy link
Member

tallytalwar commented Oct 28, 2016

Interesting this used to work before though.
Some logic did change on core label code which is causing this to happen now.

@karimnaaji
Copy link
Member

Ok so there is a regression on that side, I thought this was coming from a misusage of unified point/text style.
tangrams/tangram-es#1046

@msmollin
Copy link
Member Author

msmollin commented Nov 7, 2016

Fixed in master-1811

@msmollin msmollin closed this as completed Nov 7, 2016
@msmollin msmollin removed the ready label Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants