Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tooltip and popover to styleguide #501

Merged
merged 2 commits into from
Jun 16, 2017

Conversation

hanbyul-here
Copy link
Member

  • Added tooltip and popover styles & scripts from Bootstrap
  • Added tooltip and popover sections to styleguide page
  • Added styles needed to safely render buttons with tooltips and popovers
  • Added scripts to automatically initialize popover and tooltip

@hanbyul-here hanbyul-here requested a review from louh June 15, 2017 17:27
Copy link
Contributor

@louh louh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style changes to buttons inside of a button-group for popovers/tooltips are too intrusive. Even as implemented, this makes buttons that are next to another button lose the margins it's supposed to have.

This is a known problem to Bootstrap, but they also propose the solution:

you'll have to specify the option container: 'body' (documented below) to avoid unwanted side effects

Can we add the {container: 'body'} option when we initialize popovers and tooltips so that this happens automatically?

@hanbyul-here
Copy link
Member Author

hanbyul-here commented Jun 15, 2017 via email

@hanbyul-here hanbyul-here merged commit 5f240b8 into master Jun 16, 2017
@hanbyul-here hanbyul-here deleted the hanb/tooltip-and-popover branch June 16, 2017 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants