Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All landuse needs sort_key (default) #364

Closed
nvkelso opened this issue Oct 30, 2015 · 5 comments
Closed

All landuse needs sort_key (default) #364

nvkelso opened this issue Oct 30, 2015 · 5 comments
Assignees
Milestone

Comments

@nvkelso
Copy link
Member

nvkelso commented Oct 30, 2015

In this tile, the grass don't define sort_key:

http://vector.dev.mapzen.com/osm/all/17/38588/49285.topojson?api_key=vector-tiles-HqUVidw

{
type: "Polygon",
properties: {
id: 372703843,
source: "openstreetmap.org",
kind: "grass",
min_zoom: 12.7632,
area: 507
},
arcs: [
[
38
]
]
},
@zerebubuth
Copy link
Member

Landuse sort keys are only defined for kinds in this list, which doesn't include grass. What sort_key would you like it to have -- or is there a default that should get applied?

@nvkelso
Copy link
Member Author

nvkelso commented Oct 30, 2015

It should default to 1 (an int), since earth is 0 and landuse should default sort above that.

@nvkelso
Copy link
Member Author

nvkelso commented Oct 30, 2015

With Brett's help I've worked around this in the scene file so this doesn't need to git fixed ASAP.

@nvkelso
Copy link
Member Author

nvkelso commented Feb 26, 2016

I've sketched out proposed sort keys in the attached Open Office document.

sort_key.ods.zip

This is based on what we're doing now in server code and how that is sometimes hacked in the scene file to achieve the cartographic design.

tl;dr

  • Moves the current sort_key range from [0,40] to [0,405].
  • All feature kinds now have sort_key values, "no" duplicate values (at least for landuse, some for roads)

Design goals:

  • Allow for data "underlays" at various places in the z-orders between logical groupings (mostly between layers).
  • Allow future growth in each layer's kind values.
  • Allow some intermixing of features between layers.
  • Live within a z-fighting world, but not go crazy with per tile feature geom area sorts.

@zerebubuth, @rmarianski, @bcamper, @blair1618, @meetar, @sensescape to sanity check

@nvkelso
Copy link
Member Author

nvkelso commented Feb 26, 2016

Related: #446.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants