Upgrade bootstrap to 4.6 #46
Conversation
| overflow-x: auto; | ||
| overflow-y: hidden; | ||
| } | ||
|
|
||
| #mara-main div.card div.card-block > div.card-block-content > *:first-child { | ||
| #mara-main div.card div.list-group > div.list-group-item > *:first-child { |
There was a problem hiding this comment.
Huih, this might need an extra changelog entry that one should check the UI of the final mara app, especially if one is using some bootstrap styling in custom modules...
There was a problem hiding this comment.
Yea, right... this breaking change was introduced by 4.0. Mara still runs on a alpha version of bootstrap (#33)
There was a problem hiding this comment.
This change requires mara/mara-pipelines#66 to be merged as well. Do you have an idea how to tell pip that the next mara-app version 2.4 requires the next mara-pipelines version 3.4.0?
Currently there is no requirement between mara-app and mara-pipelines. Is there a way to tell that when package XYZ is installed, it must be above or below version 2.4/3.4.0?
There was a problem hiding this comment.
I do not know about any way to exclude certain packages, just depend on certain versions.
If there is a requirement, I would say add one? Or why do they need to be installed together? (maybe put the UI part into a special sub install target (similar to test) and declare it there (and install it per default!)? Then if someone wants to use pipelines without UI, they can install the bare minimum and not the UI?
There was a problem hiding this comment.
It looks like that default targets are not supported. See here. I think I will just merge it in the next minor version and make a note in the changelog in both repositories.
leo-schick
force-pushed
the
upgrade_bootstrap
branch
from
8feb8be
to
3343abc
Compare
A Makefile is added which makes it easy to download newer versions in the future.
leo-schick
force-pushed
the
upgrade_bootstrap
branch
from
8e2de21
to
bdb57f4
Compare
Minor upgrade for bootstrap.
Connected PRs: