Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typing + fix small issues #91

Merged
merged 2 commits into from
Feb 24, 2023
Merged

add typing + fix small issues #91

merged 2 commits into from
Feb 24, 2023

Conversation

leo-schick
Copy link
Member

Add typing for parameters + fix several small issues in code

Copy link
Member

@jankatins jankatins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...

Whats the minimum py version? It might be already enough for regular list[dict[str, str]] like annotations and x | None instead of Optiona[x]... Oh well, at some point, a pyupgrade/ruff run will fix that :-)

@leo-schick
Copy link
Member Author

@jankatins I paid attention that I don't use all the fancy new stuff becuase we still have 3.6 as minimum requirement. I dropped 3.6 from the CI tests because it isn't anymore supported (and CI tests are not available anymore).

I often hesitate to upgrade because I don't know what people use out there.
x | None requires 3.10. I am currently on 3.9 because of some package dependecies which where incompatible when I tried to upgrade the last time.

Any suggestions for a policy when we should upgrade python versions?

@jankatins
Copy link
Member

jankatins commented Feb 15, 2023

I think I remember that the initial mara version had python requirement on the "latest and greatest python" :-)

Basically up to you, but my suggestion would be to at least drop anything which is not supported anymore. Given that everybody and my mother runs stuff in a docker container that shouldn't be a big problem :-)

@leo-schick
Copy link
Member Author

@jankatins Sounds great! I think I will merge this for now and we can apply this on e.g. next major release and make python 3.11 as a minimum requirement.

@leo-schick leo-schick merged commit 1743ec9 into main Feb 24, 2023
@leo-schick leo-schick deleted the add-typing branch February 24, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants