Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft Windows telnet fails to properly connect #121

Closed
marado opened this issue Aug 23, 2020 · 2 comments
Closed

Microsoft Windows telnet fails to properly connect #121

marado opened this issue Aug 23, 2020 · 2 comments
Labels
bug hacktoberfest help wanted
Milestone
0.8.0

Comments

@marado
Copy link
Owner

marado commented Aug 23, 2020

win10-32

On Windows 10 32-bit or Windows 7 32-bit, the stock telnet client fails to properly connect to TalkerNode, as we can see on the screenshot.

Typing a letter in the "tell me your name" field, is enough to elicit a response (as if the letter had been sent with an enter).

I'm tagging this as "help wanted", since I do not have any Windows I can use to debug this with.
@marado marado added this to the 0.8.0 milestone Aug 23, 2020
thejsa added a commit to thejsa/TalkerNode that referenced this issue Oct 4, 2020
@thejsa
Buffer received data until CR-LF (fixes marado#121)
9506ee1 
Signed-off-by: Lauren Kelly <lauren.kelly@msn.com>
thejsa added a commit to thejsa/TalkerNode that referenced this issue Oct 4, 2020
@thejsa
Buffer received data until CR-LF (fixes marado#121)
932a16f 
This commit introduces input buffering, so that input from clients which
don't default to and/or support line mode (e.g, Windows' builtin client)
will be handled correctly.

Note that this does not entirely fix Windows compatibility as echo
behaviour in the MS Telnet Client differs to other implementations.

Therefore, IAC echo will need to be implemented (marado#34).

Signed-off-by: Lauren Kelly <lauren.kelly@msn.com>
marado pushed a commit that referenced this issue Oct 4, 2020
@thejsa @marado
Buffer received data until CR-LF (fixes #121)
73a51dd 
This commit introduces input buffering, so that input from clients which
don't default to and/or support line mode (e.g, Windows' builtin client)
will be handled correctly.

Note that this does not entirely fix Windows compatibility as echo
behaviour in the MS Telnet Client differs to other implementations.

Therefore, IAC echo will need to be implemented (#34).

Signed-off-by: Lauren Kelly <lauren.kelly@msn.com>
@marado marado closed this as completed in 9c8b8d6 Oct 23, 2020
@marado
Copy link
Owner Author

marado commented Oct 23, 2020

Still not totally fixed (see more info on #122 ).

@marado marado reopened this Oct 23, 2020
@marado
Copy link
Owner Author

marado commented Aug 31, 2021 •
edited
Loading

We need to buffer everything: .map, motd, .file. ... which isn't, actually, quite the same issue. I'm going to close this one, use the IAC one for the echo sittuation, and create a new one for the linebreak issues in the output (things the talker sends the client).

@marado marado closed this as completed Aug 31, 2021
This was referenced Aug 31, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug hacktoberfest help wanted
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
1 participant
@marado