Add -Wextra -Wno-compare-reals gfortran flags #306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Wall
does not actually turn on ALL warnings, so we include-Wextra
as well.However,
-Wextra
flags checking for equality between two reals with the warningAnd we want to allow those checks, so we also include
-Wno-compare-reals
.These extra checks picked up on a few unused parameters (mostly
subname
beingdeclared in a subroutine and then never used)