Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow frayed ropes from being used in other types of patterns in the decomposition #200

Open
fedarko opened this issue Dec 8, 2020 · 0 comments · May be fixed by #244
Open

Disallow frayed ropes from being used in other types of patterns in the decomposition #200

fedarko opened this issue Dec 8, 2020 · 0 comments · May be fixed by #244
Labels
hierarchical decomposition it took me a year to implement this so it had better be useful .___.

Comments

@fedarko
Copy link
Member

fedarko commented Dec 8, 2020

Splitting up #164 into separate issues for my own sanity.

This is one of the big things I've noticed looking at the visualizations in the past few days -- frayed ropes often get incorporated into other patterns when they don't really make sense there. I think erring on the side of being too conservative is best here. We can maaaybe allow frayed ropes in chains and stuff, if all of their outgoing/incoming edges kinda match up, but for now let's just enforce these as "terminal" patterns.
@fedarko fedarko added the hierarchical decomposition it took me a year to implement this so it had better be useful .___. label Dec 8, 2020
fedarko added a commit to fedarko/MetagenomeScope-1 that referenced this issue Dec 8, 2020
@fedarko
Disallow frayed ropes from being used in other patts
0b46d22 
Closes marbl#200.
fedarko added a commit to fedarko/MetagenomeScope-1 that referenced this issue Dec 8, 2020
@fedarko
TST: add first pass at testing marbl#200 done
e7dca56 
for some reason, found a really weird bug in graph decomp --
gonna see how bad it is
@fedarko fedarko linked a pull request May 16, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hierarchical decomposition it took me a year to implement this so it had better be useful .___.
Projects
None yet
Milestone
No milestone
1 participant
@fedarko