Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove module load? #14

Closed
erikenbody opened this issue Sep 21, 2020 · 2 comments
Closed

remove module load? #14

erikenbody opened this issue Sep 21, 2020 · 2 comments

Comments

@erikenbody
Copy link

Hi there,

Thanks for making this interesting and useful tool! I have found on our cluster that the lines that check if R, bedtools, and samtools are installed wrecks some havoc on getting this to run. Specifically it loads the default version of R, when packages are not all installed for whatever that default version is, and the different capitalization of bedtools (vs BEDTools).

Anyway, just wonder if simpler to assume these are installed as dependencies rather than having these hard set module load calls? I commented them all out to get my jobs to run. Just thought I'd make this suggestion if I am not unique here.

It would, for example, save time when I go to pull the latest update, to not have to comment these out :)

e.g. this:

has_module=$(check_module)
if [[ $has_module -gt 0 ]]; then
        echo "No modules available.."
else
	module load bedtools
	module load samtools
	module load R
fi

thanks!

@arangrhie
Copy link
Contributor

Hi @erikenbody , sorry to hear your struggle.
I'll remove the modules in the next release.

@erikenbody
Copy link
Author

No struggle, just a suggestion! congrats on the pub :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants