Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): I/O event decoder/encoder #272

Merged
merged 4 commits into from
Jun 20, 2020
Merged

Conversation

JozefFlakus
Copy link
Member

@JozefFlakus JozefFlakus commented Jun 16, 2020

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@JozefFlakus JozefFlakus added enhancement New feature or request scope: core Relates to @marblejs/core package labels Jun 16, 2020
@JozefFlakus JozefFlakus added this to the 3.3 milestone Jun 16, 2020
@JozefFlakus JozefFlakus self-assigned this Jun 16, 2020
@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #272 into master will decrease coverage by 0.29%.
The diff coverage is 84.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
- Coverage   95.41%   95.11%   -0.30%     
==========================================
  Files         157      158       +1     
  Lines        2769     2806      +37     
  Branches      366      315      -51     
==========================================
+ Hits         2642     2669      +27     
- Misses        123      133      +10     
  Partials        4        4              
Impacted Files Coverage Δ
...kages/core/src/http/server/http.server.listener.ts 78.26% <ø> (ø)
packages/core/src/logger/logger.interface.ts 100.00% <ø> (ø)
...rc/transport/strategies/amqp.strategy.interface.ts 81.81% <ø> (ø)
.../testing/src/testBed/http/http.testBed.response.ts 75.00% <40.00%> (-13.24%) ⬇️
packages/core/src/+internal/utils/any.util.ts 76.92% <71.42%> (-6.42%) ⬇️
...ore/src/http/response/http.responseBody.factory.ts 80.95% <73.33%> (-19.05%) ⬇️
...ckages/core/src/+internal/http/contentType.util.ts 100.00% <100.00%> (ø)
packages/core/src/+internal/utils/array.util.ts 100.00% <100.00%> (ø)
packages/core/src/error/error.model.ts 100.00% <100.00%> (ø)
packages/core/src/event/event.factory.ts 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 060e7a9...1de13d0. Read the comment docs.

@JozefFlakus JozefFlakus linked an issue Jun 16, 2020 that may be closed by this pull request
tstelzer
tstelzer previously approved these changes Jun 16, 2020
@JozefFlakus JozefFlakus changed the title feat(core): I/O event decoder feat(core): I/O event decoder/encoder Jun 17, 2020
@tstelzer
Copy link
Collaborator

Ok then, create can be as it is but anyway I would like to remove this unnecessary decoding underneath and replace it with simple encode

Yes, makes perfect sense.

tstelzer
tstelzer previously approved these changes Jun 18, 2020
@JozefFlakus JozefFlakus merged commit 22b7699 into master Jun 20, 2020
@JozefFlakus JozefFlakus deleted the feat/event-builder branch June 20, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scope: core Relates to @marblejs/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] I/O event decoder
2 participants