Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(http): content-related headers #352

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

JozefFlakus
Copy link
Member

@JozefFlakus JozefFlakus commented Aug 11, 2021

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

  • @marblejs/http - Content-Type is automatically guessed and provided only when it is not directly provided by the user, same for Content-Length header

Does this PR introduce a breaking change?

[x] Yes
[ ] No

@JozefFlakus JozefFlakus added enhancement New feature or request next Feature or enhancement that will be added in 'next' major version scope: http Relates to @marblejs/http package labels Aug 11, 2021
@JozefFlakus JozefFlakus added this to the 4.0 milestone Aug 11, 2021
@JozefFlakus JozefFlakus self-assigned this Aug 11, 2021
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #352 (1385e8f) into next (46befd6) will decrease coverage by 0.68%.
The diff coverage is 93.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #352      +/-   ##
==========================================
- Coverage   94.91%   94.22%   -0.69%     
==========================================
  Files         135      157      +22     
  Lines        2242     3084     +842     
  Branches      301      359      +58     
==========================================
+ Hits         2128     2906     +778     
- Misses        110      174      +64     
  Partials        4        4              
Impacted Files Coverage Δ
packages/core/src/logger/logger.interface.ts 100.00% <ø> (ø)
packages/core/src/operators/use/use.operator.ts 50.00% <ø> (-50.00%) ⬇️
packages/http/src/error/http.error.effect.ts 100.00% <ø> (ø)
packages/http/src/http.interface.ts 100.00% <ø> (ø)
packages/http/src/index.ts 0.00% <0.00%> (ø)
packages/http/src/router/http.router.matcher.ts 100.00% <ø> (ø)
...messaging/src/transport/strategies/tcp.strategy.ts 0.00% <0.00%> (ø)
packages/middleware-cors/src/applyHeaders.ts 100.00% <ø> (ø)
packages/middleware-cors/src/checkOrigin.ts 100.00% <ø> (ø)
packages/middleware-cors/src/configureResponse.ts 100.00% <ø> (ø)
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e3e72b...1385e8f. Read the comment docs.

@JozefFlakus JozefFlakus merged commit f7df9f9 into next Aug 11, 2021
@JozefFlakus JozefFlakus deleted the feat/lower-case-http-headers branch August 11, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next Feature or enhancement that will be added in 'next' major version scope: http Relates to @marblejs/http package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant