Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core): #contextFactory - async dependencies #376

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

JozefFlakus
Copy link
Member

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Tests

Other information

Related discussion: #372

@JozefFlakus JozefFlakus added the scope: core Relates to @marblejs/core package label Sep 22, 2021
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #376 (52f6153) into master (cbdffda) will decrease coverage by 1.34%.
The diff coverage is 92.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
- Coverage   95.41%   94.07%   -1.35%     
==========================================
  Files         157      159       +2     
  Lines        2769     3103     +334     
  Branches      366      428      +62     
==========================================
+ Hits         2642     2919     +277     
- Misses        123      180      +57     
  Partials        4        4              
Impacted Files Coverage Δ
packages/core/src/logger/logger.interface.ts 100.00% <ø> (ø)
packages/core/src/operators/index.ts 100.00% <ø> (ø)
packages/core/src/operators/use/use.operator.ts 50.00% <ø> (-50.00%) ⬇️
packages/http/src/http.interface.ts 100.00% <ø> (ø)
packages/http/src/index.ts 0.00% <0.00%> (ø)
packages/http/src/router/http.router.combiner.ts 92.30% <ø> (ø)
packages/http/src/router/http.router.matcher.ts 100.00% <ø> (ø)
...ages/http/src/router/http.router.params.factory.ts 100.00% <ø> (ø)
packages/http/src/server/http.server.interface.ts 100.00% <ø> (ø)
packages/messaging/src/reply/reply.ts 100.00% <ø> (ø)
... and 139 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22ba0ff...52f6153. Read the comment docs.

@JozefFlakus JozefFlakus merged commit 1bf362e into master Oct 27, 2021
@JozefFlakus JozefFlakus deleted the test/context-async-deps branch October 27, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: core Relates to @marblejs/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant