Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Proper event bubbling #268

Merged
merged 23 commits into from
Feb 6, 2024
Merged

feat: Proper event bubbling #268

merged 23 commits into from
Feb 6, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jul 2, 2023

Depends on #346
Closes #267

@marc2332 marc2332 added enhancement 🔥 New feature or request blocked labels Jul 2, 2023
@marc2332 marc2332 added this to the 0.2.0 milestone Jul 3, 2023
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (7c2d31d) 53.17% compared to head (b894e8b) 53.92%.
Report is 1 commits behind head on main.

❗ Current head b894e8b differs from pull request most recent head 8478bc9. Consider uploading reports for the commit 8478bc9 to get more accurate results

Files Patch % Lines
crates/components/src/scroll_views/scroll_view.rs 0.00% 12 Missing ⚠️
crates/components/src/switch.rs 0.00% 10 Missing ⚠️
crates/components/src/slider.rs 0.00% 7 Missing ⚠️
crates/core/tests/event_bubbling.rs 98.21% 3 Missing ⚠️
crates/core/src/events/events_measurer.rs 95.74% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
+ Coverage   53.17%   53.92%   +0.74%     
==========================================
  Files         151      152       +1     
  Lines       13233    13445     +212     
==========================================
+ Hits         7037     7250     +213     
+ Misses       6196     6195       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review January 26, 2024 20:00
@marc2332 marc2332 marked this pull request as draft January 26, 2024 20:01
@marc2332 marc2332 merged commit 2136277 into main Feb 6, 2024
4 checks passed
@marc2332 marc2332 deleted the feat/event-bubbling branch February 6, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Event bubbling
1 participant