Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ignore invalid nodes #589

Merged
merged 1 commit into from
Apr 27, 2024
Merged

feat: Ignore invalid nodes #589

merged 1 commit into from
Apr 27, 2024

Conversation

marc2332
Copy link
Owner

Closes #588

Copy link

Benchmark for 3a8aade

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 106.3±2.40ms 105.2±0.56ms -1.03%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 23.2±1.05ms 23.2±1.16ms 0.00%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1373.0±11.43µs 1385.2±13.18µs +0.89%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 131.6±0.81µs 129.9±0.67µs -1.29%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 23.2±0.27ms 23.6±0.99ms +1.72%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1635.3±6.11µs 1619.1±34.80µs -0.99%
benchmarks/size=19531 depth=7 wide=5 mode=cached 312.9±9.18µs 311.6±7.87µs -0.42%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.5±0.01ms 2.5±0.01ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 399.3±113.50µs 398.9±131.41µs -0.10%
benchmarks/size=54241 depth=5 wide=15 mode=cached 253.2±18.75µs 270.8±20.73µs +6.95%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.2±0.06ms 6.1±0.13ms -1.61%

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.25%. Comparing base (0ef6170) to head (49696f7).

Files Patch % Lines
crates/torin/src/measure.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
+ Coverage   73.21%   73.25%   +0.03%     
==========================================
  Files         190      191       +1     
  Lines       19107    19126      +19     
==========================================
+ Hits        13990    14010      +20     
+ Misses       5117     5116       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 merged commit 3d00862 into main Apr 27, 2024
8 checks passed
@marc2332 marc2332 deleted the feat/ignore-invalid-nodes branch April 27, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue: Provide better errors for unsupported combination of elements
1 participant