Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consider corner radius for events and overflow clipping #768

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jul 7, 2024

Closes #767

@marc2332 marc2332 added enhancement 🔥 New feature or request fix 🩹 Fixes a bug labels Jul 7, 2024
@marc2332
Copy link
Owner Author

marc2332 commented Jul 7, 2024

I am still not 100% sold in the implementation because it is only applying the viewport when rendering visually, so, events will still ignore the corner radius. I might have to rethink the viewports general idea

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 19.20668% with 387 lines in your changes missing coverage. Please review.

Project coverage is 73.63%. Comparing base (1955629) to head (5b0981e).

Files Patch % Lines
crates/core/src/elements/rect.rs 17.48% 151 Missing ⚠️
crates/core/src/skia/skia_renderer.rs 0.00% 77 Missing ⚠️
crates/core/src/elements/paragraph.rs 0.00% 52 Missing ⚠️
crates/core/src/elements/image.rs 0.00% 37 Missing ⚠️
crates/core/src/elements/svg.rs 0.00% 26 Missing ⚠️
crates/core/src/elements/label.rs 0.00% 24 Missing ⚠️
crates/core/src/elements/utils.rs 61.53% 10 Missing ⚠️
crates/renderer/src/app.rs 0.00% 7 Missing ⚠️
crates/core/src/events/events_measurer.rs 93.10% 2 Missing ⚠️
crates/testing/src/test_handler.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #768      +/-   ##
==========================================
- Coverage   73.66%   73.63%   -0.03%     
==========================================
  Files         199      200       +1     
  Lines       20377    20487     +110     
==========================================
+ Hits        15011    15086      +75     
- Misses       5366     5401      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332
Copy link
Owner Author

marc2332 commented Jul 7, 2024

I am still not 100% sold in the implementation because it is only applying the viewport when rendering visually, so, events will still ignore the corner radius. I might have to rethink the viewports general idea

This should be easy to do. Will try it asap

@marc2332 marc2332 changed the title fix: Rethink rendering of elements fix: Consider corner radius for events and overflow clipping Jul 7, 2024
@marc2332
Copy link
Owner Author

marc2332 commented Jul 7, 2024

I am still not 100% sold in the implementation because it is only applying the viewport when rendering visually, so, events will still ignore the corner radius. I might have to rethink the viewports general idea

This should be easy to do. Will try it asap

done!

@marc2332 marc2332 marked this pull request as ready for review July 7, 2024 22:19
@marc2332
Copy link
Owner Author

marc2332 commented Jul 9, 2024

todo: avoid dynamic dispatch

@marc2332 marc2332 merged commit 83e33d2 into main Jul 9, 2024
3 of 4 checks passed
@marc2332 marc2332 deleted the fix/element-rendering-rethink branch July 9, 2024 19:57
This was referenced Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request fix 🩹 Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: The overflow attribute does not take into account the value of the corner_radius attribute.
1 participant