Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set duckdb_api config option #149

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Conversation

elefeint
Copy link
Contributor

DuckDB 0.9.2 introduced PRAGMA USER_AGENT consisting of the surface API (duckdb_api) and a composable custom_user_agent.

This PR sets duckdb_api to go. And since config is now always passed when opening the database, it actually deletes more code than it adds!

@marcboeker
Copy link
Owner

@elefeint Thanks for the PR and the refactoring. Just because I'm curious: what is the idea behind setting the duckdb_api identifier?

@elefeint
Copy link
Contributor Author

It allows analysis of which surfaces of DuckDB are used. Without it, go-duckdb usage is indistinguishable from other "C api" usage.

@marcboeker marcboeker merged commit badd00c into marcboeker:main Jan 23, 2024
3 checks passed
@elefeint elefeint deleted the set_duckdb_api branch February 17, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants