Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TIMESTAMP_TZ issue in 0.10.0 #181

Closed
wants to merge 2 commits into from

Conversation

niger-prequel
Copy link

@niger-prequel niger-prequel commented Mar 5, 2024

Fixes #172

Completed

  • Update duckdb.h
  • Include serialization for DUCKDB_TYPE_TIMESTAMP_TZ

Notes

  • There may be other types that need similar treatment like DUCKDB_TYPE_TIME_TZ. I only addressed what was blocking functionality for Prequel
  • I believe this only works against the HEAD of main for DuckDB and not the v0.10.0 tag.

@taniabogatsch
Copy link
Collaborator

Updating the header will happen after DuckDB's next bug-fix release, as go-duckdb does not build cutting-edge binaries. From my understanding, the current header already includes the TIMESTAMPTZ, so the fix should work without the header changes.

@niger-prequel
Copy link
Author

@taniabogatsch reverted the header change.

@marcboeker
Copy link
Owner

@niger-prequel Thanks for the PR. I think we can close this in favor of #180?
cc @taniabogatsch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tables containing columns of type TIMESTAMPTZ cannot be queried.
3 participants