Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #229

Closed
wants to merge 1 commit into from
Closed

Update README.md #229

wants to merge 1 commit into from

Conversation

hongnod
Copy link

@hongnod hongnod commented Jun 5, 2024

One of Windows build experience.

One of Windows build experience.
@taniabogatsch
Copy link
Collaborator

Hi @hongnod! Did you manage to build and run it on Windows? We would love to add a Windows build and steps to the CI runs.

W.r.t. this PR, I prefer to move your steps into a reproducible CI run. That way, we have an example for others building on Windows, and can run our tests as well.

There has been some and discussion around Windows builds here:

@taniabogatsch taniabogatsch added the [OS] Windows [OS] Windows label Jun 6, 2024
@hongnod
Copy link
Author

hongnod commented Jun 7, 2024

Hi @hongnod! Did you manage to build and run it on Windows? We would love to add a Windows build and steps to the CI runs.
Yes, I build and run it on my home Windows and office Windows. both work. but I donn't know how to add it to CI.

@JAicewizard
Copy link
Contributor

I think this is superseded by #293 which has some simpler build steps, but thanks for working on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[OS] Windows [OS] Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants