Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added COK Trader #1

Merged
merged 2 commits into from
Dec 14, 2013
Merged

Added COK Trader #1

merged 2 commits into from
Dec 14, 2013

Conversation

greenkevon
Copy link

Created a new Trader to pull rates from COK

Created a new Trader to pull rates from COK
@marcelmorgan
Copy link
Owner

@greenkevon thanks for this. Looks good. Just 2 notes:

  1. Add a verification file for the expected rates. If you looked at the rspec output, you would see this:
  Traders COK
    # Create expected rates YAML for COK at spec/rates/cok.yml
    # ./spec/traders_spec.rb:6
  1. Commit messages are usually done in the present tense. So "add" instead of "added" (minor)

@greenkevon
Copy link
Author

Thanks Marcel. I made the updates.

@marcelmorgan
Copy link
Owner

Looking great @greenkevon. Merging...

marcelmorgan pushed a commit that referenced this pull request Dec 14, 2013
@marcelmorgan marcelmorgan merged commit 9463a38 into marcelmorgan:master Dec 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants