New asterisk commands #2
Conversation
|
Hey :) Thanks for the pull. I've made a few comments on the changes. Also, could you please squash the commits into 1? Thanks! |
|
Hi @marcelog :) I've squashed commits into 1 but i cant see any comments on code?! |
| @@ -0,0 +1,5 @@ | |||
| language: elixir | |||
There was a problem hiding this comment.
This doesn't belong to this pull, please open a different pull request if needed.
| @@ -1,4 +1,5 @@ | |||
| # ElixirAgi | |||
| [](https://travis-ci.org/alisinabh/elixir_agi) | |||
There was a problem hiding this comment.
This doesn't belong to this pull, please open a different pull request if needed.
| Sending commands that are not yet implemeted in elixir_agi is pretty easy | ||
| you can just use this function with second arg as AST Command name like "STREAM" and third arg should be a list of options for command | ||
| """ | ||
| @spec custom_cmd(t, String.t, []) :: Result.t |
There was a problem hiding this comment.
Question: What's the point of this new function if run/3 is already there?
|
Sorry, I forgot to submit the changes. Can you see them now? Thanks! |
|
Yep, resolved! sorry i thought run/3 is private :)) |
| end | ||
|
|
||
| #TODO: Implement say_* AST commands | ||
| #TODO: Implement speeck AST commands |
There was a problem hiding this comment.
There are a lot of other ones to implement, perhaps an open issue or pull request is better than these comments in the code
|
Hi @alisinabh! Thanks for the changes :) I've submitted one more, and when you're done, please squash everything into just 1 commit and I'll merge :) Best! |
AST cmd get_data implemented AST cmd get_option implemented AST cmd record_file implemented fix record_file unsafe variable custom_cmd fun in Agi Implemented custom_cmd added in README AST cmd wait_for_digit implemented AST cmd channel_status implemented fix argument naming issue in new AST commands travis build badge fix issues in review fix readme removed TODO lines
|
TODO lines removed! by the way, i don't know why are we squashing commits? i'm new to github pulls |
|
Thanks for the contribution @alisinabh! P.S: Squashing is used in this case to make it look more clean. Cheers! |
|
@marcelog thank you very much for your time! This library is gonna be so useful to me. Looking forward to improve it. 👍 Great job! |
|
Great! Thanks for your words, looking forward to merge those improvements :) All the best! |
Merge pull request marcelog#2 from alisinabh/master
Asterisk AGI commands implemented: