Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: filter by labels #261

Closed
wants to merge 5 commits into from
Closed

Conversation

hanzili
Copy link
Contributor

@hanzili hanzili commented Oct 9, 2024

#239

Screen.Recording.2024-10-08.at.22.15.28.mov

@madhav-relish
Copy link
Contributor

Shouldn't the filtering handled by BE @sajdakabir , Because as the time goes and more integrations are added the number of items per user will increasing i.e. if I have 200 items, the REST api isn't going to return me all 200 in one go. We can add page_size

What are your thoughts on this?

@sajdakabir
Copy link
Contributor

sajdakabir commented Oct 9, 2024

Yep, I was thinking the same thing and have already started working on filtering and searching APIs.

@hanzili when label filtering is ready, I will ping you and you can use that.

update: it done in this pr #263 @hanzili @madhav-relish

Copy link
Contributor

@oliursahin oliursahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • for dropdown menu, use the same ui pattern used in other places as in no filed color only a border. follow same text size as space name texts.

  • if Im in liked lebel, items added should be automatically be in that lebel. currently it does not show up as its going to 'all'

  • filter for all lebel " only show items which are not lebeled as archive or liked, /on clicking like or archive dont show them there_ move them to their group/lebel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants