-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the screenshots in the different browsers equal in size #13
Comments
@amit2rockon I am pretty sure many of the settings of browsers are system dependent. For me images are not coming same in size. |
Instead of scaling, it would be more precise if we could get the same screenshot sizes directly. If we can't do that, I guess scaling would be an acceptable fallback solution.
This happens sometimes, but I think it's a problem of the screenshotting. We simply need to crop the image to the usual size in those cases. |
Some solutions to remove the scrollbars at the source are described here: https://stackoverflow.com/questions/9449562/how-to-remove-scrollbar-in-chromedriver-how-to-change-http-agent. I think the Another possible solution is to use mobile emulation for Chromium: https://sites.google.com/a/chromium.org/chromedriver/mobile-emulation. The last possible solution I see is to cut the scrollbar from the screenshots. |
It looks like |
We should now make sure the screenshots are the same in size. Maybe we need to collect them in a VM or something like that to make sure everyone is collecting the sime size. Or maybe we can find another way to ensure it. |
#184 might fix this. |
Right now, Chrome is showing a scrollbar that we should get rid of, as it is simply adding noise.
Once we remove the scrollbar, the screenshots are probably not the same size in Firefox and Chrome, so we should adjust it to be the same.
The text was updated successfully, but these errors were encountered: