Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_labels.py is not actually testing the screenshots actually exist #245

Closed
sagarvijaygupta opened this issue Jul 25, 2018 · 3 comments
Closed

test_labels.py is not actually testing the screenshots actually exist #245

sagarvijaygupta opened this issue Jul 25, 2018 · 3 comments

Comments

@sagarvijaygupta
Copy link
Collaborator

autowebcompat/tests/test_labels.py

Line 10 in 9dd4b2b

assert os.path.join('data', '{}_{}.png'.format(label, browser))

Should be changed to

os.path.exists(os.path.join('data', '{}_{}.png'.format(label, browser)))
sagarvijaygupta added a commit to sagarvijaygupta/autowebcompat that referenced this issue Jul 25, 2018
@sagarvijaygupta
Bug fix in testing screenshot exists in data directory.
a9bbc4b 
Solves marco-c#245
@sagarvijaygupta sagarvijaygupta mentioned this issue Jul 25, 2018
Merged
@sagarvijaygupta
Copy link
Collaborator Author

5478_4
5478_4
5991
6081_3
6081_3
7490_4
7490_4
8371
8371
9084_6
9084_6
@marco-c these labels are present in your csv file but not uploaded in gitlab

@marco-c
Copy link
Owner

marco-c commented Jul 25, 2018

@marco-c these labels are present in your csv file but not uploaded in gitlab

Ah yes, it's because I have some additional screenshots on my machine that I haven't pushed yet...

@marco-c
Copy link
Owner

marco-c commented Jul 25, 2018

Since they are just a few, would you mind removing them manually as part of #246?

@marco-c marco-c changed the title Incorrect test_labels.py test_labels.py is not actually testing the screenshots actually exist Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marco-c @sagarvijaygupta