Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the write_labels tests to make sure read_labels can read labels written by write_labels #165

Merged
merged 11 commits into from
Mar 31, 2018

Conversation

anujanegi
Copy link
Contributor

@anujanegi anujanegi commented Mar 29, 2018

Fixes #68.

@marco-c marco-c changed the title Expanded the write_labels tests to make sure read_labels can read labels written by write_labels Expand the write_labels tests to make sure read_labels can read labels written by write_labels Mar 31, 2018
@marco-c
Copy link
Owner

marco-c commented Mar 31, 2018

The test is failing, so you will have to change it a bit.
Make the label object more close to the actual one we are storing with labels.py (keys are strings, values are strings).

Copy link
Owner

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, marking as "changes requested" until the tests are passing.

@codecov-io
Copy link

Codecov Report

Merging #165 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #165      +/-   ##
=========================================
+ Coverage   24.51%   24.6%   +0.09%     
=========================================
  Files          11      11              
  Lines         820     821       +1     
  Branches       97      97              
=========================================
+ Hits          201     202       +1     
  Misses        617     617              
  Partials        2       2
Impacted Files Coverage Δ
tests/test_utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5048aa...47d5951. Read the comment docs.

@marco-c marco-c merged commit f9de4a0 into marco-c:master Mar 31, 2018
@propr
Copy link

propr bot commented Mar 31, 2018

Please provide your feedback on this pull request here.

Privacy statement: We don't store any personal information such as your email address or name. We ask for GitHub authentication as an anonymous identifier to account for duplicate feedback entries and to see people specific preferences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants