Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in config message name #57

Closed
RdeWilde opened this issue Jul 20, 2019 · 1 comment
Closed

Typo in config message name #57

RdeWilde opened this issue Jul 20, 2019 · 1 comment
Labels
bug Something isn't working config

Comments

@RdeWilde
Copy link

kroto-plus/protoc-gen-kroto-plus/src/main/proto/krotoplus/compiler/config.proto

Line 121 in 720fdf3

message ExtenableMessagesGenOptions{

@marcoferrer marcoferrer changed the title Typo Typo in config message name Jul 23, 2019
@marcoferrer
Copy link
Owner

Thanks for reporting this. This is a relatively safe change to make. Its up for grabs if you'd like, else I'll get a PR up later tonight.

@marcoferrer marcoferrer added bug Something isn't working config labels Aug 2, 2019
marcoferrer added a commit that referenced this issue Aug 4, 2019
@marcoferrer
fix typo in config message name (#57)
757da7f
marcoferrer added a commit that referenced this issue Aug 22, 2019
@marcoferrer
Outbound flow control bugfix (#61)
0454f13 
* update dependencies

* fix typo in config message name (#57)

* clean up usages of deprecated apis

* fix race condition in unit back-pressure test

* add test from @chris-blacker for high volume race condition

* fix race condition in outbound flow control handler

* update outbound flow control

* propagate scope cancellation to target channel in outbound flow control

* configure detailed test output

* add bidi streaming integration tests

* propagate client inbound channel close as call cancellation

* close outbound message handler in server call handlers

* improve determinism of tests

* add withContext to atomic server bidi streaming test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working config
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RdeWilde @marcoferrer