Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bidi flowcontrol bugfix and back pressure tests #47

Merged
merged 5 commits into from
May 1, 2019

Conversation

marcoferrer
Copy link
Owner

Disable auto inbound flow control for inbound client and server call streams.

@marcoferrer marcoferrer changed the title Bidi flowcontrol bugfix Bidi flowcontrol bugfix and back pressure tests Apr 9, 2019
@codecov-io
Copy link

codecov-io commented Apr 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@fff5835). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #47   +/-   ##
==========================================
  Coverage           ?   88.88%           
  Complexity         ?       19           
==========================================
  Files              ?       15           
  Lines              ?      279           
  Branches           ?       37           
==========================================
  Hits               ?      248           
  Misses             ?       13           
  Partials           ?       18
Impacted Files Coverage Δ Complexity Δ
...oferrer/krotoplus/coroutines/server/ServerCalls.kt 86.25% <100%> (ø) 0 <0> (?)
...otoplus/coroutines/client/ClientBidiCallChannel.kt 100% <100%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff5835...7d82bce. Read the comment docs.

@marcoferrer marcoferrer merged commit 88997bc into develop May 1, 2019
marcoferrer added a commit that referenced this pull request Jun 18, 2019
* disable auto inbound flow control for bidi calls

* add client streaming back pressure test

* verify send message count on stream call
marcoferrer added a commit that referenced this pull request Jun 18, 2019
* disable auto inbound flow control for bidi calls

* add client streaming back pressure test

* verify send message count on stream call
@marcoferrer marcoferrer deleted the bidi-flowcontrol-bugfix branch August 23, 2019 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants