Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build native executable artifacts #87

Merged
merged 5 commits into from
Nov 19, 2019
Merged

Conversation

marcoferrer
Copy link
Owner

@marcoferrer marcoferrer commented Nov 15, 2019

This PR should resolve the existing issues around executing the protoc plugins on windows.
It will allow each of the kroto plugins to behave as a native platform executable. The strategy used is an adaptation of the work being done in salesforce/grpc-java-contrib/canteen

This will also simplify artifact configuration in the protobuf gradle plugin.

Issue #83 should be fully resolved by this.
Issue #6 will be partially resolved.

@codecov-io
Copy link

codecov-io commented Nov 15, 2019

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #87   +/-   ##
=========================================
  Coverage     85.29%   85.29%           
  Complexity       19       19           
=========================================
  Files            15       15           
  Lines           306      306           
  Branches         49       49           
=========================================
  Hits            261      261           
  Misses           16       16           
  Partials         29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b978f5f...29ab6ea. Read the comment docs.

@marcoferrer marcoferrer merged commit 7fef300 into master Nov 19, 2019
@marcoferrer marcoferrer deleted the build-native-artifacts branch November 19, 2019 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants