Fixed coverals

marcomontalbano · Sep 6, 2017 · b281ade · b281ade
1 parent 5fc840b
commit b281ade
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 17 deletions.
diff --git a/dist/jquery.jcreate.js b/dist/jquery.jcreate.js
@@ -79,11 +79,9 @@
         },
         remove: function(handleObj) {
             for (var _createList_key in _createList) {
-                if (_createList.hasOwnProperty(_createList_key)) {
-                    if ($(this).is(_createList[_createList_key].$delegateTarget) && _createList[_createList_key].handleObj.selector === handleObj.selector) {
-                        delete _createList[_createList_key];
-                        break;
-                    }
+                if (_createList.hasOwnProperty(_createList_key) && $(this).is(_createList[_createList_key].$delegateTarget) && _createList[_createList_key].handleObj.selector === handleObj.selector) {
+                    delete _createList[_createList_key];
+                    break;
                 }
             }
         },

diff --git a/dist/jquery.jcreate.min.js.map b/dist/jquery.jcreate.min.js.map
diff --git a/dist/jquery.jcreate.umd.js b/dist/jquery.jcreate.umd.js
@@ -95,11 +95,9 @@
         },
         remove: function(handleObj) {
             for (var _createList_key in _createList) {
-                if (_createList.hasOwnProperty(_createList_key)) {
-                    if ($(this).is(_createList[_createList_key].$delegateTarget) && _createList[_createList_key].handleObj.selector === handleObj.selector) {
-                        delete _createList[_createList_key];
-                        break;
-                    }
+                if (_createList.hasOwnProperty(_createList_key) && $(this).is(_createList[_createList_key].$delegateTarget) && _createList[_createList_key].handleObj.selector === handleObj.selector) {
+                    delete _createList[_createList_key];
+                    break;
                 }
             }
         },

diff --git a/spec/utlity.spec.js b/spec/utlity.spec.js
@@ -23,4 +23,17 @@ describe('jQuery.event.special.create.utility', function()
         expect( jQuery.event.special.create.utility.filterDataByKey({width: 10, productKey:1, productName:'Android'}, 'product') ).toEqual({key:1, name:'Android'});
         expect( jQuery.event.special.create.utility.filterDataByKey('this is a string!', 'product') ).toEqual('this is a string!');
     });
+
+    it('.filterDataByKey() shouldn\'t break if the array object has been extended.', function()
+    {
+        // given
+        Array.prototype.newCoolFunction  = function() {};
+        Object.prototype.newCoolFunction = function() {};
+
+        // then
+        expect(function() {
+            expect( jQuery.event.special.create.utility.filterDataByKey({width: 10, productKey:1, productName:'Android'}, 'product') ).toEqual({key:1, name:'Android'});
+            expect( jQuery.event.special.create.utility.filterDataByKey('this is a string!', 'product') ).toEqual('this is a string!');
+        }).not.toThrow();
+    });
 });
diff --git a/src/jquery.jcreate.js b/src/jquery.jcreate.js
@@ -197,13 +197,10 @@
         {
             for (var _createList_key in _createList)
             {
-                if ( _createList.hasOwnProperty( _createList_key ) )
+                if( _createList.hasOwnProperty( _createList_key ) && $(this).is( _createList[_createList_key].$delegateTarget ) && _createList[_createList_key].handleObj.selector === handleObj.selector )
                 {
-                    if( $(this).is( _createList[_createList_key].$delegateTarget ) && _createList[_createList_key].handleObj.selector === handleObj.selector )
-                    {
-                        delete _createList[_createList_key];
-                        break;
-                    }
+                    delete _createList[_createList_key];
+                    break;
                 }
             }
         },