Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as rework for the
fit
method in PredMap, but ended up being bigger. Here is a summary:fit_transform
on test data.I think the old
fit
method had a lot of unnecessary actions. This version runs the test data much faster (~1min) than the previous one (~3min). I also changed some parameters for the RandomizedSearchCV that partially (totally?) addresses #31 with more messages. Significant changes are included though, and we should check if everything is working as expected - drops in performance are expected due tofit_transform
bug.