Add support for typing.Literal #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dictionary key, and add verbosity to exception messages
…s to bottom of file, and remove dead code
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
=======================================
Coverage 99.29% 99.30%
=======================================
Files 26 26
Lines 1560 1578 +18
Branches 285 289 +4
=======================================
+ Hits 1549 1567 +18
Misses 3 3
Partials 8 8
|
… cases to increase code coverage
|
@marcosschroh unable to add you as a reviewer, so doing a manual ping. Whenever you have time |
… as unions when a default value is present
…rals as typehook was removed
marcosschroh
approved these changes
Sep 28, 2023
@marcosschroh sure thing! Thanks for walking me through the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for fields annotated with
typing.Literalin line with PEP 586. It also adds support for dictionaries annotated with a key whose type is a class derived fromstr(e.g.StrEnum) and adds verbosity to exception messages to help with debugging (particularly in nested models when it's difficult to identify the problem field).