fix: generate proper python identifiers when generating model from sc… #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #639 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 33 33
Lines 1851 1856 +5
=======================================
+ Hits 1842 1847 +5
Misses 9 9 ☔ View full report in Codecov by Sentry. |
marcosschroh
force-pushed
the
fix/generate-valid-python-identifiers-when-a-model-is-generated
branch
2 times, most recently
from
8154ab8
to
c2a839d
Compare
…hemas. Related to #628
marcosschroh
force-pushed
the
fix/generate-valid-python-identifiers-when-a-model-is-generated
branch
from
c2a839d
to
0d94200
Compare
marcosschroh
deleted the
fix/generate-valid-python-identifiers-when-a-model-is-generated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hemas. Related to #628