Added option to undo last renaming operation #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtimkovich
approved these changes
Mar 9, 2023
src/main.rs
Outdated
Comment on lines
356
to
366
| // make paths absolute to that undo does not depend on CWD | ||
| let original = if r.original.is_relative() { | ||
| std::env::current_dir()?.join(r.original) | ||
| } else { | ||
| r.original | ||
| }; | ||
| let new = if r.new.is_relative() { | ||
| std::env::current_dir()?.join(r.new) | ||
| } else { | ||
| r.new | ||
| }; |
There was a problem hiding this comment.
could you make a function for converting the relative path to an absolute one so we don't repeat here?
| if opts.undo { | ||
| let replacements = load_undo_renames(backup_file)?; | ||
| execute_renames(&replacements, opts.rename_command)?; | ||
| return Ok(()); |
There was a problem hiding this comment.
optional: Do you want to add some output here for when the undo completes successfully?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added the command line option "--undo" to undo the last renaming operation.
Do you think this might be a useful feature? If this works reliably we could also think about giving the "--yes" flag by default (and adding an "--interative" flag).