Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to prebuilt openssl binaries #321

Closed
wants to merge 3 commits into from
Closed

Conversation

GNUGradyn
Copy link
Contributor

Hello. as discussed on Discord, building for Android (at least on Windows) is currently broken due to the openssl prefab being broken. I've reported this to Google (https://issuetracker.google.com/issues/341136039). In the mean time, I am suggesting we include the OpenSSL binaries. These are 1.1.1u binaries because modern OpenSSL is not backwards compatible this far. I've also built some 3.2.1 binaries and I'll include those in an issue. Here is the script I wrote to build openSSL in case you want to audit it and compare my binaries to the result https://gist.github.com/GNUGradyn/50ed6a4b09fc744097fcef6140f4e826

Copy link
Contributor

@shamilovtim shamilovtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google responded and said there's nothing wrong with the openssl bin. Personally I am not in favor of adding massive amounts of complexity just to support Windows, which should be used with WSL anyways.

@boorad
Copy link
Collaborator

boorad commented May 21, 2024

Yeah, I checked this PR out as well, and I'm not feeling it. Not sure what to do here to help you out.

I did see a random old (ish) version of NDK in the library's gradle rig, but I don't think it was getting set/used due to a bug I introduced. Maybe try specifying ndkVersion in your local.properties file? i.e. ndkVersion = "25.1.8937393" or maybe the fix is to have a snippet like this in build.gradle:

  defaultConfig {
    ...
    ndkVersion safeExtGet('ndkVersion', '25.1.8937393')
    ...

@boorad boorad closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants