Skip to content

Commit cadd826

Browse files
committed
[TODO-5373] properly closing cursor for pypy
1 parent 64cc1b0 commit cadd826

File tree

1 file changed

+13
-19
lines changed

1 file changed

+13
-19
lines changed

testing/test/integration/test_cursor.py

Lines changed: 13 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1274,27 +1274,21 @@ def test_conpy62(self):
12741274
self.assertEqual(row[0], Decimal(1.25))
12751275
del cur
12761276

1277-
@unittest.skipIf(
1278-
os.environ.get('PYTHON_VERSION', '').startswith('pypy'),
1279-
"Test skipped for PyPy"
1280-
)
12811277
def test_conpy67(self):
12821278
with create_connection() as con:
1283-
cur = con.cursor(buffered=False)
1284-
cur.execute("SELECT 1")
1285-
self.assertEqual(cur.rowcount, 0)
1286-
cur = con.cursor()
1287-
cur.execute("SELECT 1", buffered=False)
1288-
self.assertEqual(cur.rowcount, 0)
1289-
cur.close()
1290-
1291-
cur = con.cursor()
1292-
cur.execute("CREATE TEMPORARY TABLE test_conpy67 (a int)")
1293-
cur.execute("SELECT * from test_conpy67")
1294-
self.assertEqual(cur.rowcount, 0)
1295-
cur.fetchall()
1296-
self.assertEqual(cur.rowcount, 0)
1297-
del cur
1279+
with con.cursor(buffered=False) as cur:
1280+
cur.execute("SELECT 1")
1281+
self.assertEqual(cur.rowcount, 0)
1282+
with con.cursor() as cur:
1283+
cur.execute("SELECT 1", buffered=False)
1284+
self.assertEqual(cur.rowcount, 0)
1285+
1286+
with con.cursor() as cur:
1287+
cur.execute("CREATE TEMPORARY TABLE test_conpy67 (a int)")
1288+
cur.execute("SELECT * from test_conpy67")
1289+
self.assertEqual(cur.rowcount, 0)
1290+
cur.fetchall()
1291+
self.assertEqual(cur.rowcount, 0)
12981292

12991293
def test_negative_numbers(self):
13001294
with create_connection() as con:

0 commit comments

Comments
 (0)